Page MenuHomePhabricator

Remove duplicate inline scaffold in 2up renderer
ClosedPublic

Authored by epriestley on Mar 6 2015, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 10:37 AM
Unknown Object (File)
Thu, Feb 29, 11:17 AM
Unknown Object (File)
Feb 14 2024, 10:55 PM
Unknown Object (File)
Feb 14 2024, 10:25 PM
Unknown Object (File)
Feb 14 2024, 3:17 PM
Unknown Object (File)
Feb 14 2024, 3:08 PM
Unknown Object (File)
Feb 13 2024, 7:22 PM
Unknown Object (File)
Jan 26 2024, 10:15 AM
Subscribers

Details

Summary

Ref T2009. Remove the 4 (!!) copies of this code.

Test Plan
  • Added, edited, and removed inline comments in 2up view.
  • Stacked a bunch of comments on the same line and saw the JS place them correctly.
  • Created an image diff and added, edited and removed inlines on it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove duplicate inline scaffold in 2up renderer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:59 PM
This revision was automatically updated to reflect the committed changes.