Page MenuHomePhabricator

Rename inline comment views to "PHUIDiff" and give them a base class
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:13 PM.
Tags
None
Referenced Files
F18106250: D11996.id.diff
Sun, Aug 10, 10:02 PM
F18106087: D11996.id28894.diff
Sun, Aug 10, 9:06 PM
F18105923: D11996.diff
Sun, Aug 10, 8:35 PM
F18093914: D11996.id28884.diff
Thu, Aug 7, 9:22 PM
F18089580: D11996.id28884.diff
Wed, Aug 6, 11:48 AM
F18048494: D11996.id28894.diff
Sun, Aug 3, 1:36 PM
F18048493: D11996.id28884.diff
Sun, Aug 3, 1:36 PM
F18048492: D11996.id.diff
Sun, Aug 3, 1:36 PM
Subscribers

Details

Summary

Ref T2009. These classes are "Differential" now, but are used elsewhere in diff infrastructure (e.g., Diffusion).

  • Rename them to "PHUIDiff".
  • Move them to "src/infrastructure/".
  • Give them a base class.
Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Rename inline comment views to "PHUIDiff" and give them a base class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.