Page MenuHomePhabricator

Fix another issue with line order on unified diffs
ClosedPublic

Authored by epriestley on Mar 5 2015, 11:47 PM.
Tags
None
Referenced Files
F15458894: D11992.diff
Mon, Mar 31, 8:02 AM
F15434085: D11992.id28875.diff
Tue, Mar 25, 1:55 AM
F15410699: D11992.id28876.diff
Wed, Mar 19, 8:12 AM
F15403556: D11992.id28875.diff
Tue, Mar 18, 3:52 AM
F15381465: D11992.id28876.diff
Fri, Mar 14, 7:47 AM
F15333860: D11992.id28876.diff
Sat, Mar 8, 5:13 AM
Unknown Object (File)
Feb 26 2025, 4:24 AM
Unknown Object (File)
Feb 1 2025, 11:13 AM
Subscribers

Details

Summary

This improves some cases with interleaved added and removed lines, and adds test coverage.

Test Plan
  • Added and executed unit tests.
  • Viewed raw diff and saw sensible/expected output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix another issue with line order on unified diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 12:22 AM
This revision was automatically updated to reflect the committed changes.