Page MenuHomePhabricator

Improve behavior of inline rendering with unified views
ClosedPublic

Authored by epriestley on Mar 5 2015, 7:26 PM.
Tags
None
Referenced Files
F14347876: D11988.diff
Thu, Dec 19, 3:49 AM
Unknown Object (File)
Mon, Dec 16, 5:21 PM
Unknown Object (File)
Thu, Dec 12, 9:25 PM
Unknown Object (File)
Tue, Dec 10, 1:51 PM
Unknown Object (File)
Mon, Dec 9, 9:17 PM
Unknown Object (File)
Sat, Dec 7, 3:35 AM
Unknown Object (File)
Thu, Dec 5, 4:42 PM
Unknown Object (File)
Thu, Dec 5, 3:09 AM
Subscribers

Details

Summary

Ref T2009. This reduces how buggy inlines are. They're still buggy.

Specifically, the inline endpoint didn't know how to scaffold inlines before, so some of them ended up rendering in the wrong rows or breaking layouts.

This passes the current renderer through to the inline editor endpoint, so it can at least get the layout correct.

Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Branch
uni12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4769
Build 4785: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve behavior of inline rendering with unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.