Page MenuHomePhabricator

Improve behavior of inline rendering with unified views
ClosedPublic

Authored by epriestley on Mar 5 2015, 7:26 PM.

Details

Summary

Ref T2009. This reduces how buggy inlines are. They're still buggy.

Specifically, the inline endpoint didn't know how to scaffold inlines before, so some of them ended up rendering in the wrong rows or breaking layouts.

This passes the current renderer through to the inline editor endpoint, so it can at least get the layout correct.

Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 28847.Mar 5 2015, 7:26 PM
epriestley retitled this revision from to Improve behavior of inline rendering with unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Mar 5 2015, 9:08 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.