Page MenuHomePhabricator

Improve behavior of inline rendering with unified views
ClosedPublic

Authored by epriestley on Mar 5 2015, 7:26 PM.
Tags
None
Referenced Files
F19050342: D11988.diff
Thu, Nov 27, 7:44 PM
F19014876: D11988.id28847.diff
Sat, Nov 22, 9:50 PM
F18835740: D11988.diff
Oct 26 2025, 6:30 PM
F18823609: D11988.id.diff
Oct 23 2025, 12:39 PM
F18821160: D11988.diff
Oct 22 2025, 7:49 PM
F18811403: D11988.id28847.diff
Oct 20 2025, 3:11 AM
F18784315: D11988.id28847.diff
Oct 13 2025, 12:19 PM
F18784314: D11988.id28870.diff
Oct 13 2025, 12:19 PM
Subscribers

Details

Summary

Ref T2009. This reduces how buggy inlines are. They're still buggy.

Specifically, the inline endpoint didn't know how to scaffold inlines before, so some of them ended up rendering in the wrong rows or breaking layouts.

This passes the current renderer through to the inline editor endpoint, so it can at least get the layout correct.

Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve behavior of inline rendering with unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.