Page MenuHomePhabricator
Differential D11987

Fix an issue where inlines appear in the wrong place in one-up views
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 6:59 PM.
Tags
None
Referenced Files
F14372489: D11987.diff
Fri, Dec 20, 7:53 PM
Unknown Object (File)
Tue, Dec 17, 10:49 AM
Unknown Object (File)
Tue, Dec 17, 4:34 AM
Unknown Object (File)
Sun, Dec 15, 10:52 AM
Unknown Object (File)
Thu, Dec 12, 2:58 AM
Unknown Object (File)
Sat, Dec 7, 11:07 AM
Unknown Object (File)
Thu, Dec 5, 9:13 PM
Unknown Object (File)
Tue, Dec 3, 9:15 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPa8c9f2e8b09f: Fix an issue where inlines appear in the wrong place in one-up views
Summary

Ref T2009. Unchanged lines should always go above inlines; we get nonsense results otherwise.

Test Plan

Inline now shows in correct place in unified view.

Diff Detail

Repository
rP Phabricator
Branch
uni11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4773
Build 4789: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28846.Mar 5 2015, 6:59 PM
epriestley retitled this revision from to Fix an issue where inlines appear in the wrong place in one-up views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 6:59 PM
btrahan accepted this revision.Mar 5 2015, 9:05 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/render/DifferentialChangesetRenderer.php
523

s/unchagned/unchanged

This revision is now accepted and ready to land.Mar 5 2015, 9:05 PM
epriestley updated this revision to Diff 28855.Mar 5 2015, 9:27 PM
epriestley edited edge metadata.
  • Typo fix.
Closed by commit rPa8c9f2e8b09f: Fix an issue where inlines appear in the wrong place in one-up views (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
9 lines

Diff 28855

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Loading...
Phabricator · Built by Phacility