Page MenuHomePhabricator
Differential D11985

Add "Copy" and "Coverage" columns to unified view
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 5:45 PM.
Tags
None
Referenced Files
F13268295: D11985.diff
Wed, May 29, 4:53 AM
F13252001: D11985.diff
Sat, May 25, 12:59 AM
F13248807: D11985.id28840.diff
Fri, May 24, 4:11 AM
F13219437: D11985.id.diff
Sat, May 18, 6:21 PM
F13215813: D11985.id28869.diff
Fri, May 17, 8:05 PM
Unknown Object (File)
Fri, May 3, 5:53 AM
Unknown Object (File)
Apr 29 2024, 3:38 AM
Unknown Object (File)
Apr 25 2024, 12:58 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPbd5985e67db6: Add "Copy" and "Coverage" columns to unified view
Summary

These aren't being populated yet; they mostly fix some JS errors with inlines.

For example, the inline hover reticle relies on adjusting its width to account for the "copy" column, and failed when the column did not exist.

Test Plan
  • Hovering inlines in unified now works, mostly.
  • Interacted with inlines in side-by-side.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28840.Mar 5 2015, 5:45 PM
epriestley retitled this revision from to Add "Copy" and "Coverage" columns to unified view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a reviewer: chad. · View Herald TranscriptMar 5 2015, 5:45 PM
Herald added a subscriber: epriestley. · View Herald Transcript
btrahan accepted this revision.Mar 5 2015, 9:04 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 9:04 PM
Closed by commit rPbd5985e67db6: Add "Copy" and "Coverage" columns to unified view (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
applications/
differential/
render/
41 lines
16 lines
webroot/
rsrc/
css/
application/
differential/
4 lines
js/
application/
differential/
1 line

Diff 28869

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility