Page MenuHomePhabricator
Differential D11976

Render "Show Context" blocks in unified view
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 3:34 PM
Unknown Object (File)
Mon, Dec 9, 1:55 AM
Unknown Object (File)
Nov 9 2024, 4:59 PM
Unknown Object (File)
Nov 9 2024, 4:25 PM
Unknown Object (File)
Nov 9 2024, 4:00 PM
Unknown Object (File)
Nov 4 2024, 2:28 PM
Unknown Object (File)
Oct 29 2024, 12:59 PM
Unknown Object (File)
Oct 16 2024, 6:10 PM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP06df75ebbd4f: Render "Show Context" blocks in unified view
Summary

Ref T2009. This basically copy/pastes them for now. Plans is:

  • Make this actually work all the way.
  • Add test coverage after D11970.
  • Move 2-up here after test coverage.

Clicking the links does not work yet, because they use the 2-up renderer. I'll fix this in the next diff.

Test Plan

Viewed diffs in unified, saw links to show more.

Diff Detail

Repository
rP Phabricator
Branch
uni5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:88XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4755
Build 4771: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28827.Mar 5 2015, 2:06 PM
epriestley retitled this revision from to Render "Show Context" blocks in unified view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 2:06 PM
chad added a subscriber: chad.Mar 5 2015, 3:13 PM
chad added inline comments.
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
469

Show %d Lines

btrahan accepted this revision.Mar 5 2015, 8:45 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 8:45 PM
Closed by commit rP06df75ebbd4f: Render "Show Context" blocks in unified view (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
88 lines
21 lines
3 lines
infrastructure/
internationalization/
translation/
26 lines

Diff 28827

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility