Page MenuHomePhabricator
Differential D11971

Fix bad method signature
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 6:11 AM
Unknown Object (File)
Sat, Dec 21, 3:06 AM
Unknown Object (File)
Sun, Dec 8, 3:27 AM
Unknown Object (File)
Nov 30 2024, 12:30 AM
Unknown Object (File)
Nov 28 2024, 10:12 PM
Unknown Object (File)
Nov 28 2024, 10:12 PM
Unknown Object (File)
Nov 28 2024, 9:56 PM
Unknown Object (File)
Nov 21 2024, 4:46 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP8df36b8f0c60: Fix bad method signature
Summary

This ended up having a different signature; the discrepancy can cause a warning.

Test Plan

No more warning.

Diff Detail

Repository
rP Phabricator
Branch
signature
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4750
Build 4766: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28822.Mar 5 2015, 1:11 AM
epriestley retitled this revision from to Fix bad method signature.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 1:11 AM
btrahan accepted this revision.Mar 5 2015, 6:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 6:12 PM
Closed by commit rP8df36b8f0c60: Fix bad method signature (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 6:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
4 lines

Diff 28822

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility