Page MenuHomePhabricator
Differential D11969

Fix an issue with creating new Conpherences
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 11:42 AM
Unknown Object (File)
Sat, Jan 18, 7:47 AM
Unknown Object (File)
Tue, Jan 7, 5:42 PM
Unknown Object (File)
Dec 25 2024, 5:43 PM
Unknown Object (File)
Dec 10 2024, 10:26 PM
Unknown Object (File)
Dec 3 2024, 7:49 PM
Unknown Object (File)
Nov 28 2024, 10:13 PM
Unknown Object (File)
Nov 28 2024, 10:13 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP803a05082471: Fix an issue with creating new Conpherences
Summary

The participant list can sometimes be null, which fails when we try to array_fuse() it.

Test Plan

Created a new thread cleanly.

Diff Detail

Repository
rP Phabricator
Branch
con1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4747
Build 4761: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28817.Mar 4 2015, 10:27 PM
epriestley retitled this revision from to Fix an issue with creating new Conpherences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 10:27 PM
btrahan accepted this revision.Mar 4 2015, 10:35 PM
btrahan edited edge metadata.

I thought maybe it was possible to fix this in initializeNewThread on ConpherenceThread, then I noticed we also have ConpherenceEditor::createConpherence... Anyway, this works for me.

This revision is now accepted and ready to land.Mar 4 2015, 10:35 PM
Closed by commit rP803a05082471: Fix an issue with creating new Conpherences (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 10:36 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Mar 4 2015, 10:38 PM

Yeah, I figure we can merge some of that stuff and get test coverage on it eventually. I think Conpherence mostly predates the widespread use of initializeNew....

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
editor/
2 lines
transactions/
editor/
2 lines

Diff 28817

View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility