Paths

Table of Contentst

Differential D11969

Fix an issue with creating new Conpherences
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 10:27 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP803a05082471: Fix an issue with creating new Conpherences

Summary

The participant list can sometimes be null, which fails when we try to array_fuse() it.

Test Plan

Created a new thread cleanly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28817.Mar 4 2015, 10:27 PM

epriestley retitled this revision from to Fix an issue with creating new Conpherences.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 10:27 PM

I thought maybe it was possible to fix this in initializeNewThread on ConpherenceThread, then I noticed we also have ConpherenceEditor::createConpherence... Anyway, this works for me.

This revision is now accepted and ready to land.Mar 4 2015, 10:35 PM

Closed by commit rP803a05082471: Fix an issue with creating new Conpherences (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 10:36 PM

This revision was automatically updated to reflect the committed changes.

Yeah, I figure we can merge some of that stuff and get test coverage on it eventually. I think Conpherence mostly predates the widespread use of initializeNew....

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

editor/

ConpherenceEditor.php

2 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 28818

View Options

src/applications/conpherence/editor/ConpherenceEditor.php