Page MenuHomePhabricator

Fix an issue with creating new Conpherences
ClosedPublic

Authored by epriestley on Mar 4 2015, 10:27 PM.
Tags
None
Referenced Files
F12838166: D11969.id28817.diff
Thu, Mar 28, 5:56 PM
Unknown Object (File)
Feb 23 2024, 11:49 AM
Unknown Object (File)
Feb 21 2024, 10:18 PM
Unknown Object (File)
Feb 15 2024, 5:03 AM
Unknown Object (File)
Feb 15 2024, 3:09 AM
Unknown Object (File)
Feb 15 2024, 2:59 AM
Unknown Object (File)
Feb 10 2024, 8:59 AM
Unknown Object (File)
Feb 7 2024, 2:24 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP803a05082471: Fix an issue with creating new Conpherences
Summary

The participant list can sometimes be null, which fails when we try to array_fuse() it.

Test Plan

Created a new thread cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with creating new Conpherences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I thought maybe it was possible to fix this in initializeNewThread on ConpherenceThread, then I noticed we also have ConpherenceEditor::createConpherence... Anyway, this works for me.

This revision is now accepted and ready to land.Mar 4 2015, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Yeah, I figure we can merge some of that stuff and get test coverage on it eventually. I think Conpherence mostly predates the widespread use of initializeNew....