Differential D11963

Show "Show Older" for transactions the user has not interacted with
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 12:19 PM.

Tags

None

Referenced Files

	F15510886: D11963.id28804.diff
	Wed, Apr 16, 9:50 PM

	F15507233: D11963.id28804.diff
	Tue, Apr 15, 5:44 PM

	F15507085: D11963.id.diff
	Tue, Apr 15, 4:13 PM

	F15504122: D11963.diff
	Mon, Apr 14, 4:00 PM

	F15504033: D11963.diff
	Mon, Apr 14, 3:15 PM

	F15462413: D11963.id28812.diff
	Tue, Apr 1, 3:01 PM

	F15460393: D11963.id.diff
	Mon, Mar 31, 10:34 PM

	F15425767: D11963.id28804.diff
	Sun, Mar 23, 5:57 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows)

Commits

Restricted Diffusion Commit
rPb09168e689ff: Show "Show Older" for transactions the user has not interacted with

Summary

Fixes T7454. We weren't triggering "Show Older" unless there were hidden events because of a previous interaction.

Test Plan

Set page size to 3.
Viewed a task with ~10 transactions.
Before patch:
- Only 3 most recent transactions visible, no way to see older ones.
- Saw "show older" appear, paged backward through transaction histroy.
Also, interacted with task and then viewed it, made sure "show older" still works.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28804.Mar 4 2015, 12:19 PM

epriestley retitled this revision from to Show "Show Older" for transactions the user has not interacted with.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows).

Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 12:19 PM

btrahan accepted this revision.Mar 4 2015, 6:25 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 4 2015, 6:25 PM

Closed by commit rPb09168e689ff: Show "Show Older" for transactions the user has not interacted with (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 6:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

control/

AphrontCursorPagerView.php

4 lines

phui/

PHUITimelineView.php

21 lines

Diff 28812

src/view/control/AphrontCursorPagerView.php

Loading...

src/view/phui/PHUITimelineView.php

Loading...