This moves global search results to use standard UI, and hopefully allow us to easily add more information.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPa2ece038c6aa: Convert search results to use PHUIObjectItemView
Tested a number of open and closed task queries, tried a few users and projects. All seem to work well.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- search-results-list
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4726 Build 4740: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
It would also be nice to know what other information might be available to return in the results for 'free', like object name, status color, fulltext snippet that was matched... anything useful?
Comment Actions
There isn't too much we can pick up for free (for instance, statuses don't have universal colors). We can probably get some stuff cheaply if there's anything specific you're after, although nothing relevant springs to mind for me offhand.
I think we can do snippets in MySQL somewhat-cheaply but we'd have to do our own matching. I'm less sure we can do them in ElasticSearch.
Comment Actions
I think there are maybe three (likely easy) things that could help global search.
- Snippets (as in, show me why this was matched)
- Grouping (group results by type, perhaps a design challenge)
- Collapse "advanced" panel, like ApplicationSearch already does. (make people click 'edit query' to go advanced