Differential D11948

Convert search results to use PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on Mar 3 2015, 5:16 AM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPa2ece038c6aa: Convert search results to use PHUIObjectItemView

Summary

This moves global search results to use standard UI, and hopefully allow us to easily add more information.

Test Plan

Tested a number of open and closed task queries, tried a few users and projects. All seem to work well.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28773.Mar 3 2015, 5:16 AM

chad retitled this revision from to Convert search results to use PHUIObjectItemView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 3 2015, 5:16 AM

chad edited the test plan for this revision. (Show Details)Mar 3 2015, 5:18 AM

It would also be nice to know what other information might be available to return in the results for 'free', like object name, status color, fulltext snippet that was matched... anything useful?

There isn't too much we can pick up for free (for instance, statuses don't have universal colors). We can probably get some stuff cheaply if there's anything specific you're after, although nothing relevant springs to mind for me offhand.

I think we can do snippets in MySQL somewhat-cheaply but we'd have to do our own matching. I'm less sure we can do them in ElasticSearch.

This revision is now accepted and ready to land.Mar 3 2015, 9:46 AM

Closed by commit rPa2ece038c6aa: Convert search results to use PHUIObjectItemView (authored by chad, committed by chad). · Explain WhyMar 3 2015, 3:18 PM

This revision was automatically updated to reflect the committed changes.

I think there are maybe three (likely easy) things that could help global search.

Snippets (as in, show me why this was matched)
Grouping (group results by type, perhaps a design challenge)
Collapse "advanced" panel, like ApplicationSearch already does. (make people click 'edit query' to go advanced