Differential D11940

Stop mangling filenames when downloading them
ClosedPublic
Actions

Authored by epriestley on Mar 3 2015, 1:53 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T6990: Filenames downloaded get mangled when not latin based

Commits

Restricted Diffusion Commit
rP5952b0a31b6a: Stop mangling filenames when downloading them

Summary

Fixes T6990. We unnecessarily mangle filenames when downloading them.

Test Plan

Reviewed "quoted-string" grammar in HTTP spec (http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html)
Downloaded some non-latin binaries.

Diff Detail

Repository

rP Phabricator

Branch

fileresponse

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4718
Build 4732: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28762.Mar 3 2015, 1:53 AM

epriestley retitled this revision from to Stop mangling filenames when downloading them.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6990: Filenames downloaded get mangled when not latin based.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 3 2015, 1:53 AM

btrahan accepted this revision.Mar 3 2015, 2:56 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 2:56 AM

Closed by commit rP5952b0a31b6a: Stop mangling filenames when downloading them (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 11:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

AphrontFileResponse.php

6 lines

Diff 28762

View Options

src/aphront/response/AphrontFileResponse.php

Stop mangling filenames when downloading themClosedPublicActions