Page MenuHomePhabricator
Differential D11939

Fix not blocking / not blocked queries
ClosedPublic
Actions

Authored by epriestley on Mar 3 2015, 12:55 AM.

Details

Reviewers
btrahan
Maniphest Tasks
T7434: "Show Tasks Not Blocked By Other Tasks" now never returns any results
Commits
Restricted Diffusion Commit
rPa76049abd401: Fix not blocking / not blocked queries
Summary

Fixes T7434. We need to LEFT JOIN, not JOIN here, because we still want result rows where the value is null.

Test Plan

Issued blocked/not-blocked + blocking/not-blocking queries, got results in all cases.

Diff Detail

Repository
rP Phabricator
Branch
block
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4717
Build 4731: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28760.Mar 3 2015, 12:55 AM
epriestley retitled this revision from to Fix not blocking / not blocked queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7434: "Show Tasks Not Blocked By Other Tasks" now never returns any results.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 3 2015, 12:55 AM
btrahan accepted this revision.Mar 3 2015, 12:59 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2015, 12:59 AM
Closed by commit rPa76049abd401: Fix not blocking / not blocked queries (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 1:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
4 lines

Diff 28760

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
Phabricator · Built by Phacility