Differential D11931

Restore "Query:" to page title in application search
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 4:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?

Commits

Restricted Diffusion Commit
rPa0e9762968a1: Restore "Query:" to page title in application search

Summary

Fixes T7055. Omitting this from the crumbs is an improvement, but page titles like "New" seem better with a little more context.

Test Plan

Saw "Query:" in page titles only.

Diff Detail

Repository

rP Phabricator

Branch

qtitle

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4707
Build 4721: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28739.Mar 2 2015, 4:37 PM

epriestley retitled this revision from to Restore "Query:" to page title in application search.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 4:37 PM

chad accepted this revision.Mar 2 2015, 4:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2015, 4:42 PM

Closed by commit rPa0e9762968a1: Restore "Query:" to page title in application search (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorApplicationSearchController.php

2 lines

Diff 28739

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Restore "Query:" to page title in application searchClosedPublicActions