Page MenuHomePhabricator
Differential D11930

Support ssh-ed25519 SSH keys
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 4:25 PM.
Tags
None
Referenced Files
F15545726: D11930.id.diff
Sat, Apr 26, 12:18 PM
F15545725: D11930.id28737.diff
Sat, Apr 26, 12:18 PM
F15545724: D11930.id28744.diff
Sat, Apr 26, 12:18 PM
F15545643: D11930.diff
Sat, Apr 26, 11:49 AM
F15529119: D11930.id28744.diff
Tue, Apr 22, 4:58 PM
F15523542: D11930.id28737.diff
Mon, Apr 21, 2:05 AM
F15518285: D11930.id28737.diff
Sat, Apr 19, 12:31 PM
F15515175: D11930.id.diff
Fri, Apr 18, 8:28 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7121: Support for new SSH key algos (ssh-ed25519)
Commits
Restricted Diffusion Commit
rP8fd77ff4f8a5: Support ssh-ed25519 SSH keys
Summary

Fixes T7121.

Test Plan

Used ssh-keygen -t ed25519 on an Ubuntu 14 box to generate a key; verified this is the header on the corresponding public key.

Diff Detail

Repository
rP Phabricator
Branch
ed25519
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4706
Build 4720: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28737.Mar 2 2015, 4:25 PM
epriestley retitled this revision from to Support ssh-ed25519 SSH keys.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7121: Support for new SSH key algos (ssh-ed25519).
Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 4:25 PM
btrahan accepted this revision.Mar 2 2015, 5:55 PM
btrahan edited edge metadata.

Haha, I was scared of this diff by title, but that's a nice one line change you've got right there.

This revision is now accepted and ready to land.Mar 2 2015, 5:55 PM
epriestley added a comment.Mar 2 2015, 5:56 PM

Haha, yeah.

This check is just here to help make sure users don't accidentally put things which aren't public keys into the form (worst case: private keys), so we don't need to do anything fancy.

Closed by commit rP8fd77ff4f8a5: Support ssh-ed25519 SSH keys (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
sshkey/
1 line

Diff 28737

View Options

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

Loading...
Phabricator · Built by Phacility