Paths

Table of Contentst

Differential D11930

Support ssh-ed25519 SSH keys
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 4:25 PM.

Tags

None

Referenced Files

	F14080653: D11930.diff
	Fri, Nov 22, 3:39 PM

	Unknown Object (File)
	Wed, Nov 20, 8:13 PM

	Unknown Object (File)
	Wed, Nov 20, 6:06 PM

	Unknown Object (File)
	Sun, Nov 17, 11:02 PM

	Unknown Object (File)
	Thu, Nov 14, 6:42 AM

	Unknown Object (File)
	Sun, Nov 10, 12:48 AM

	Unknown Object (File)
	Wed, Nov 6, 3:02 PM

	Unknown Object (File)
	Thu, Oct 24, 2:35 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7121: Support for new SSH key algos (ssh-ed25519)

Commits

Restricted Diffusion Commit
rP8fd77ff4f8a5: Support ssh-ed25519 SSH keys

Summary

Fixes T7121.

Test Plan

Used ssh-keygen -t ed25519 on an Ubuntu 14 box to generate a key; verified this is the header on the corresponding public key.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28737.Mar 2 2015, 4:25 PM

epriestley retitled this revision from to Support ssh-ed25519 SSH keys.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7121: Support for new SSH key algos (ssh-ed25519).

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 4:25 PM

Haha, I was scared of this diff by title, but that's a nice one line change you've got right there.

This revision is now accepted and ready to land.Mar 2 2015, 5:55 PM

Haha, yeah.

This check is just here to help make sure users don't accidentally put things which aren't public keys into the form (worst case: private keys), so we don't need to do anything fancy.

Closed by commit rP8fd77ff4f8a5: Support ssh-ed25519 SSH keys (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

sshkey/

PhabricatorAuthSSHPublicKey.php

1 line

Diff 28744

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

Loading...