Fix quickstart.sql for old MySQL
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 4:13 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Commits

Summary

Fixes T7422. After the recent fix for "sort" columns, we can end up with invalid SQL in some cases when running quickstart.

In particular, we do "COLLATE binary CHARACTER SET utf8_general_ci" (which is invalid).

Preprocess these so we get "COLLATE utf8 CHARACTER SET utf8_general_ci" (which is valid and correct).

Test Plan

Ran bin/storage upgrade -f --namespace blahblhbaba with and without --disable-utf8mb4.

Repository

rP Phabricator

Branch

storage2

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	resources/sql/quickstart.sql:290	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1267	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1276	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1290	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1364	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1392	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1686	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1727	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1744	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1820	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1915	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1987	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:1988	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:2472	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:2503	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:2538	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:2547	TXT3	Line Too Long
Warning	resources/sql/quickstart.sql:2603	TXT3	Line Too Long

Unit