Page MenuHomePhabricator

Fix a newline issue in "arc" workflows
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:39 PM.
Tags
None
Referenced Files
F13088241: D11927.diff
Thu, Apr 25, 1:21 AM
Unknown Object (File)
Thu, Mar 28, 9:27 AM
Unknown Object (File)
Dec 17 2023, 8:01 PM
Unknown Object (File)
Dec 16 2023, 2:17 PM
Unknown Object (File)
Dec 13 2023, 1:16 AM
Unknown Object (File)
Nov 4 2023, 8:34 AM
Unknown Object (File)
Oct 28 2023, 7:06 PM
Unknown Object (File)
Sep 3 2023, 7:21 PM
Subscribers

Details

Summary

We end up with one too few newline here in some workflows, like arc land with unstaged changes.

Root issue here is that phutil_console_prompt|confirm lead with too much whitespace but that's a harder fix.

Test Plan

Saw reasonable whitespace.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a newline issue in "arc" workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.