Page MenuHomePhabricator

Fix a newline issue in "arc" workflows
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:39 PM.
Tags
None
Referenced Files
F19819343: D11927.id28738.diff
Fri, Mar 6, 5:36 AM
F19620037: D11927.id.diff
Feb 4 2026, 11:39 AM
F19030581: D11927.id28738.diff
Nov 24 2025, 9:42 PM
F19000133: D11927.id28731.diff
Nov 20 2025, 10:57 PM
F18808165: D11927.diff
Oct 19 2025, 5:12 AM
F18756821: D11927.id28731.diff
Oct 5 2025, 1:43 PM
F18712460: D11927.id.diff
Sep 29 2025, 5:24 AM
F18638195: D11927.id28731.diff
Sep 17 2025, 10:00 AM
Subscribers

Details

Summary

We end up with one too few newline here in some workflows, like arc land with unstaged changes.

Root issue here is that phutil_console_prompt|confirm lead with too much whitespace but that's a harder fix.

Test Plan

Saw reasonable whitespace.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a newline issue in "arc" workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.