Page MenuHomePhabricator

Improve error messages when specifying bad set or list to bin/config
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 16 2025, 5:50 AM
Unknown Object (File)
Jun 15 2025, 5:25 AM
Unknown Object (File)
May 6 2025, 5:54 PM
Unknown Object (File)
Apr 25 2025, 4:30 PM
Unknown Object (File)
Mar 30 2025, 2:12 PM
Unknown Object (File)
Feb 8 2025, 2:47 AM
Unknown Object (File)
Feb 8 2025, 2:47 AM
Unknown Object (File)
Feb 8 2025, 2:47 AM
Subscribers

Details

Summary

Fixes T7308. Multiple users have encountered confusion around how they should specify a set or list in JSON; provide examples.

Test Plan
epriestley@orbital ~/dev/phabricator $ ./bin/config set files.image-mime-types true
Usage Exception: Config key 'files.image-mime-types' is of type 'set'. Specify it in JSON. For example:

    ./bin/config set '{"value1": true, "value2": true}'

epriestley@orbital ~/dev/phabricator $ ./bin/config set cluster.addresses true
Usage Exception: Config key 'cluster.addresses' is of type 'list<string>'. Specify it in JSON. For example:

    ./bin/config set '["a", "b", "c"]'

epriestley@orbital ~/dev/phabricator $

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve error messages when specifying bad set or list to bin/config.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:04 PM
This revision was automatically updated to reflect the committed changes.