Page MenuHomePhabricator
Differential D11920

Replace context bar in Maniphest with PHUIInfoView
ClosedPublic
Actions

Authored by chad on Mar 1 2015, 11:43 PM.
Tags
None
Referenced Files
F13282399: D11920.diff
Sun, Jun 2, 12:01 PM
F13277391: D11920.id28719.diff
Fri, May 31, 10:44 AM
F13267750: D11920.diff
Wed, May 29, 4:09 AM
F13253182: D11920.diff
Sat, May 25, 2:28 AM
F13251275: D11920.id.diff
Fri, May 24, 9:41 PM
F13231585: D11920.diff
Tue, May 21, 12:35 AM
F13217765: D11920.id28721.diff
Sat, May 18, 7:57 AM
F13210650: D11920.diff
Fri, May 17, 5:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP89dbe8a99556: Replace context bar in Maniphest with PHUIInfoView
Summary

Removes AphrontContext bar and uses PHUIInfoView instead. This also attaches to the ObjectBox instead for cleaner UI. Also moved phui-error-view.css which was missed.

Test Plan

Test creating a subtask or a new task, see updated info bar and action buttons.

Diff Detail

Repository
rP Phabricator
Branch
similar-task
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4696
Build 4710: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28719.Mar 1 2015, 11:43 PM
chad retitled this revision from to Replace context bar in Maniphest with PHUIInfoView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 1 2015, 11:43 PM
chad edited the test plan for this revision. (Show Details)Mar 1 2015, 11:45 PM
chad updated this revision to Diff 28720.Mar 1 2015, 11:46 PM
chad edited the test plan for this revision. (Show Details)
  • Actually delete AphrontContextBarView
epriestley accepted this revision.Mar 2 2015, 12:02 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 12:02 AM
Closed by commit rP89dbe8a99556: Replace context bar in Maniphest with PHUIInfoView (authored by chad, committed by chad). · Explain WhyMar 2 2015, 12:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
2 lines
applications/
maniphest/
controller/
53 lines
view/
layout/
webroot/
rsrc/
css/
aphront/
phui/
phui-info-view.css
phui-error-view.css
4 lines

Diff 28720

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/view/layout/AphrontContextBarView.php

Loading...
View Options

webroot/rsrc/css/aphront/context-bar.css

Loading...
View Options

webroot/rsrc/css/phui/phui-error-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-info-view.css

Loading...
Phabricator · Built by Phacility