Differential D11917

Identify builtin files and give them open policies
ClosedPublic
Actions

Authored by epriestley on Mar 1 2015, 4:19 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7379: Give builtin files runtime policies

Commits

Restricted Diffusion Commit
rPd1eda610fac6: Identify builtin files and give them open policies

Summary

Fixes T7379. Currently, builtin files generate with a "users" view policy even if an install is public.

Because these files TTL after 7 days, there's no migration here. Installs won't see the fix actually happen for up to 7 days after updating, though.

Test Plan

Deleted a builtin.
Loaded projects page to regenerate it.
Saw new builtin had most open policy and was marked as a builtin.

Diff Detail

Repository

rP Phabricator

Branch

builtin

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4689
Build 4703: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28706.Mar 1 2015, 4:19 PM

epriestley retitled this revision from to Identify builtin files and give them open policies.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7379: Give builtin files runtime policies.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 1 2015, 4:19 PM

btrahan accepted this revision.Mar 1 2015, 6:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2015, 6:44 PM

Closed by commit rPd1eda610fac6: Identify builtin files and give them open policies (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2015, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileInfoController.php

9 lines

storage/

PhabricatorFile.php

25 lines

Diff 28706

View Options

src/applications/files/controller/PhabricatorFileInfoController.php