Page MenuHomePhabricator

Minor fix for `lipsum generate`
ClosedPublic

Authored by joshuaspence on Feb 28 2015, 11:16 AM.
Tags
None
Referenced Files
F14059923: D11908.diff
Sun, Nov 17, 10:38 PM
F14046268: D11908.diff
Wed, Nov 13, 7:53 PM
F14042531: D11908.id28696.diff
Tue, Nov 12, 4:10 AM
F14041211: D11908.id28686.diff
Mon, Nov 11, 4:39 PM
F14041166: D11908.id.diff
Mon, Nov 11, 4:26 PM
F14041123: D11908.diff
Mon, Nov 11, 4:04 PM
F14035031: D11908.id28696.diff
Sun, Nov 10, 3:38 AM
F14034199: D11908.diff
Sat, Nov 9, 10:45 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP644b05ec08ff: Minor fix for `lipsum generate`
Summary

I was hitting the following error when attempting to use ./bin/lipsum generate:

[2015-02-28 21:55:00] ERROR 2: array_rand(): Second argument has to be between 1 and the number of elements in the array at [/usr/src/phabricator/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php:93]
arcanist(head=master, ref.master=d8182cf55d50), phabricator(head=master, ref.master=658175925931), phutil(head=master, ref.master=260e6105dee5)
  #0 array_rand(array, integer) called at [<phabricator>/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php:93]
  #1 PhabricatorPholioMockTestDataGenerator::generateImages() called at [<phabricator>/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php:30]
  #2 PhabricatorPholioMockTestDataGenerator::generate() called at [<phabricator>/src/applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php:67]
  #3 PhabricatorLipsumGenerateWorkflow::infinitelyGenerate(array) called at [<phabricator>/src/applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php:36]
  #4 PhabricatorLipsumGenerateWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:396]
  #5 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:292]
  #6 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/lipsum/manage_lipsum.php:21]
Test Plan

Ran ./bin/lipsum generate and received less errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Minor fix for `lipsum generate`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.