Page MenuHomePhabricator
Differential D11891

Make base font a Celerity CSS variable
ClosedPublic
Actions

Authored by chad on Feb 26 2015, 4:36 AM.
Tags
None
Referenced Files
F14347854: D11891.diff
Thu, Dec 19, 3:43 AM
Unknown Object (File)
Wed, Dec 18, 3:14 AM
Unknown Object (File)
Sat, Dec 14, 3:26 PM
Unknown Object (File)
Wed, Dec 11, 10:12 AM
Unknown Object (File)
Tue, Dec 10, 8:08 PM
Unknown Object (File)
Thu, Dec 5, 12:13 PM
Unknown Object (File)
Thu, Dec 5, 8:23 AM
Unknown Object (File)
Thu, Dec 5, 7:55 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP1236043472ce: Make base font a Celerity CSS variable
Summary

For consistency, we switch back to base font in a few places when using alternate fonts like source-sans or monospace, this makes sure the base font is consistently reset.

Test Plan

Review a Document, a Diff, and a Legalpad form

Diff Detail

Repository
rP Phabricator
Branch
celerity-font
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4653
Build 4667: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28648.Feb 26 2015, 4:36 AM
chad retitled this revision from to Make base font a Celerity CSS variable.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 26 2015, 4:36 AM
chad updated this revision to Diff 28649.Feb 26 2015, 4:36 AM
  • Minor tweak
chad updated this revision to Diff 28650.Feb 26 2015, 4:38 AM
  • Removing previous diff derp
epriestley accepted this revision.Feb 26 2015, 1:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2015, 1:34 PM
Closed by commit rP1236043472ce: Make base font a Celerity CSS variable (authored by chad, committed by chad). · Explain WhyFeb 26 2015, 5:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
applications/
celerity/
4 lines
webroot/
rsrc/
css/
application/
config/
3 lines
differential/
4 lines
core/
3 lines
phui/
2 lines
19 lines
2 lines

Diff 28648

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/CelerityResourceTransformer.php

Loading...
View Options

webroot/rsrc/css/application/config/config-template.css

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/css/phui/phui-fontkit.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
Phabricator · Built by Phacility