Page MenuHomePhabricator

Only SIGINT the daemon itself, not its entire process group
ClosedPublic

Authored by epriestley on Feb 25 2015, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 11:07 PM
Unknown Object (File)
Sun, Mar 10, 5:09 AM
Unknown Object (File)
Sun, Mar 3, 3:46 PM
Unknown Object (File)
Sun, Mar 3, 11:40 AM
Unknown Object (File)
Feb 14 2024, 11:09 AM
Unknown Object (File)
Feb 1 2024, 6:43 PM
Unknown Object (File)
Jan 29 2024, 11:47 AM
Unknown Object (File)
Dec 6 2023, 11:43 AM
Subscribers

Details

Summary

Signaling the process group is correct for SIGTERM and SIGKILL (nongraceful exits) but not for SIGINT (graceful exit). Subprocesses of the daemon may exit abruptly on SIGINT, which is not consistent with the requested behavior ("exit gracefully").

Test Plan

Ran bin/phd start, bin/phd stop.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Only SIGINT the daemon itself, not its entire process group.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, btrahan.
hach-que edited edge metadata.

Tested with P1728 and saw the expected behaviour.

This revision is now accepted and ready to land.Feb 25 2015, 10:32 PM
This revision was automatically updated to reflect the committed changes.