Page MenuHomePhabricator
Differential D11869

Clean up Remarkup Code Block Headers
ClosedPublic
Actions

Authored by chad on Feb 23 2015, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Thu, Dec 19, 8:30 PM
Unknown Object (File)
Sat, Dec 7, 2:04 AM
Unknown Object (File)
Thu, Dec 5, 12:38 PM
Unknown Object (File)
Nov 11 2024, 7:18 AM
Unknown Object (File)
Nov 5 2024, 12:08 AM
Unknown Object (File)
Oct 29 2024, 4:16 AM
Unknown Object (File)
Oct 23 2024, 8:27 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6904: Titled code blocks are ugly-ish (on my computer)
Commits
Restricted Diffusion Commit
rPad48b7b93475: Clean up Remarkup Code Block Headers
Summary

Removes the special background and fonts. Uses just a simple bold header.

Test Plan

Checked out installation guide and remarkup guide in Diviner. Looks cleaner.

Screen_Shot_2015-02-23_at_3.13.29_PM.png (1×1 px, 243 KB)

Screen_Shot_2015-02-23_at_3.13.40_PM.png (1×1 px, 242 KB)

Diff Detail

Repository
rP Phabricator
Branch
code-header-remarkup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4623
Build 4637: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28586.Feb 23 2015, 11:15 PM
chad retitled this revision from to Clean up Remarkup Code Block Headers.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 23 2015, 11:15 PM
chad edited the test plan for this revision. (Show Details)Feb 23 2015, 11:16 PM
chad added a task: T6904: Titled code blocks are ugly-ish (on my computer).Feb 23 2015, 11:21 PM
chad added a comment.Feb 27 2015, 11:24 PM

Is this change OK, or was there some feedback / direction that should instead be pursued?

epriestley accepted this revision.Feb 27 2015, 11:33 PM
epriestley edited edge metadata.

Oh, sorry, it just slipped by.

I did like tying the name to the block visually, but this is definitely better overall.

This revision is now accepted and ready to land.Feb 27 2015, 11:33 PM
chad added a comment.Feb 27 2015, 11:34 PM

The main problem is the header is outside the color (yellow/red) box, and it seemed like we're just using this as a mini-header anyways.

Closed by commit rPad48b7b93475: Clean up Remarkup Code Block Headers (authored by chad, committed by chad). · Explain WhyFeb 27 2015, 11:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
17 lines

Diff 28586

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility