Page MenuHomePhabricator
Differential D11867

Move PHUIErrorView to PHUIInfoView
ClosedPublic
Actions

Authored by chad on Feb 23 2015, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:51 PM
Unknown Object (File)
Wed, Apr 10, 10:16 PM
Unknown Object (File)
Sat, Apr 6, 9:25 AM
Unknown Object (File)
Fri, Apr 5, 6:28 AM
Unknown Object (File)
Mar 23 2024, 9:28 PM
Unknown Object (File)
Mar 21 2024, 9:38 PM
Unknown Object (File)
Mar 11 2024, 8:20 PM
Unknown Object (File)
Jan 28 2024, 4:55 AM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPc038c643f498: Move PHUIErrorView to PHUIInfoView
Summary

Since this element isn't strictly about errors, re-label as info view instead.

Test Plan

Grepped for all callsites, tested UIExamples and a few other random pages.

Diff Detail

Repository
rP Phabricator
Branch
PHUIInfoView
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4692
Build 4706: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28583.Feb 23 2015, 8:41 PM
chad retitled this revision from to Move PHUIErrorView to PHUIInfoView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald TranscriptFeb 23 2015, 8:41 PM
epriestley accepted this revision.Feb 28 2015, 9:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2015, 9:54 PM
epriestley added a comment.Mar 1 2015, 10:27 PM

rSAAS will need to be updated after this lands, too.

chad added a comment.Mar 1 2015, 10:28 PM

oh, should I get this in now then?

epriestley added a comment.Mar 1 2015, 10:29 PM

No rush. Ideally, do the rSAAS change too and land them together? Not sure if the Instances app is working in your sandbox right now, though.

chad updated this revision to Diff 28714.Mar 1 2015, 10:45 PM
chad edited edge metadata.
  • re-grep for locations
Closed by commit rPc038c643f498: Move PHUIErrorView to PHUIInfoView (authored by chad, committed by chad). · Explain WhyMar 1 2015, 10:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
2 lines
src/
8 lines
aphront/
configuration/
2 lines
applications/
almanac/
controller/
4 lines
auth/
controller/
2 lines
8 lines
4 lines
2 lines
4 lines
config/
6 lines
provider/
2 lines
2 lines
calendar/
controller/
2 lines
16 lines
config/
controller/
10 lines
4 lines
4 lines
conpherence/
controller/
2 lines
daemon/
controller/
4 lines
dashboard/
controller/
4 lines
4 lines
differential/
controller/
4 lines
2 lines
12 lines
view/
2 lines
diffusion/
controller/
8 lines
10 lines
4 lines
4 lines
2 lines
4 lines
panel/
4 lines
view/
10 lines
diviner/
controller/
4 lines
fact/
controller/
4 lines
feed/
builder/
4 lines
harbormaster/
controller/
2 lines
2 lines
herald/
controller/
12 lines
home/
controller/
4 lines
legalpad/
controller/
14 lines
query/
4 lines
maniphest/
controller/
4 lines
4 lines
meta/
controller/
2 lines
notification/
controller/
2 lines
oauthserver/
controller/
4 lines
passphrase/
controller/
2 lines
people/
controller/
8 lines
4 lines
2 lines
phame/
controller/
4 lines
post/
4 lines
8 lines
phortune/
controller/
4 lines
2 lines
phragment/
controller/
4 lines
2 lines
2 lines
phriction/
controller/
24 lines
4 lines
policy/
controller/
2 lines
ponder/
controller/
4 lines
releeph/
controller/
request/
4 lines
search/
controller/
2 lines
settings/
panel/
4 lines
2 lines
uiexample/
examples/
PHUIInfoExample.php
PHUIErrorExample.php
30 lines
view/
2 lines
form/
PHUIInfoView.php
PHUIErrorView.php
16 lines
phui/
10 lines
4 lines
4 lines
calendar/
2 lines
webroot/
rsrc/
css/
application/
dashboard/
4 lines
phame/
2 lines
profile/
2 lines
phui/
2 lines
80 lines
2 lines
8 lines

Diff 28714

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Loading...
View Options

src/applications/almanac/controller/AlmanacController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorEmailLoginController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionMirrorEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php

Loading...
View Options

src/applications/diffusion/view/DiffusionEmptyResultView.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...
View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanRunController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepAddController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEditEmailController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleInviteSendController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleLdapController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
View Options

src/applications/phame/controller/PhameController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostNewController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartViewController.php

Loading...
View Options

src/applications/phortune/controller/PhortunePaymentMethodCreateController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentCreateController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentUpdateController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyEditController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorConduitCertificateSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...
View Options

src/applications/uiexample/examples/PHUIErrorExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIInfoExample.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/form/PHUIErrorView.php

Loading...
View Options

src/view/form/PHUIInfoView.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

src/view/phui/PHUIPinboardView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/application/profile/profile-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
View Options

webroot/rsrc/css/phui/phui-error-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility