Page MenuHomePhabricator

Move PHUIErrorView to PHUIInfoView
ClosedPublic

Authored by chad on Feb 23 2015, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 9:28 PM
Unknown Object (File)
Thu, Mar 21, 9:38 PM
Unknown Object (File)
Mon, Mar 11, 8:20 PM
Unknown Object (File)
Jan 28 2024, 4:55 AM
Unknown Object (File)
Jan 7 2024, 1:44 PM
Unknown Object (File)
Jan 7 2024, 1:44 PM
Unknown Object (File)
Dec 24 2023, 2:44 PM
Unknown Object (File)
Dec 23 2023, 12:12 PM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPc038c643f498: Move PHUIErrorView to PHUIInfoView
Summary

Since this element isn't strictly about errors, re-label as info view instead.

Test Plan

Grepped for all callsites, tested UIExamples and a few other random pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Move PHUIErrorView to PHUIInfoView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2015, 9:54 PM

rSAAS will need to be updated after this lands, too.

oh, should I get this in now then?

No rush. Ideally, do the rSAAS change too and land them together? Not sure if the Instances app is working in your sandbox right now, though.

chad edited edge metadata.
  • re-grep for locations
This revision was automatically updated to reflect the committed changes.