Page MenuHomePhabricator
Differential D11844

Correct logic in PHUIActionPanelView
ClosedPublic
Actions

Authored by chad on Feb 21 2015, 4:42 AM.
Tags
None
Referenced Files
F15505912: D11844.id28544.diff
Tue, Apr 15, 6:55 AM
F15419318: D11844.id28548.diff
Mar 21 2025, 5:16 AM
F15392293: D11844.id28544.diff
Mar 15 2025, 2:20 PM
F15384845: D11844.id.diff
Mar 14 2025, 9:00 PM
F15344350: D11844.id28543.diff
Mar 10 2025, 3:58 AM
Unknown Object (File)
Mar 1 2025, 2:14 AM
Unknown Object (File)
Jan 31 2025, 5:58 AM
Unknown Object (File)
Jan 29 2025, 9:07 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP1d5825c695f4: Correct logic in PHUIActionPanelView
Summary

We should only be adding space then a status is set, not a state.

Test Plan

Test on UIExamples, still renders as expected.

Diff Detail

Repository
rP Phabricator
Branch
action-panel
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4594
Build 4608: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28543.Feb 21 2015, 4:42 AM
chad retitled this revision from to Correct logic in PHUIActionPanelView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 21 2015, 4:42 AM
chad updated this revision to Diff 28544.Feb 21 2015, 4:53 AM
  • also make status clickable
epriestley accepted this revision.Feb 21 2015, 10:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2015, 10:32 AM
Closed by commit rP1d5825c695f4: Correct logic in PHUIActionPanelView (authored by chad, committed by chad). · Explain WhyFeb 21 2015, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
7 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 28544

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility