Page MenuHomePhabricator
Differential D11841

Fix fatal in XHProf
ClosedPublic
Actions

Authored by chad on Feb 20 2015, 10:05 PM.
Tags
None
Referenced Files
F18333148: D11841.id28537.diff
Mon, Aug 25, 3:56 AM
F17869665: D11841.id.diff
Mon, Jul 28, 11:59 AM
Unknown Object (File)
May 7 2025, 12:28 PM
Unknown Object (File)
Apr 25 2025, 3:05 AM
Unknown Object (File)
Apr 14 2025, 7:17 AM
Unknown Object (File)
Apr 13 2025, 9:06 AM
Unknown Object (File)
Mar 26 2025, 8:37 PM
Unknown Object (File)
Mar 14 2025, 2:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP3304d7a34107: Fix fatal in XHProf
Summary

4th times the charm? There is some confusion with Headers that could be simplified, obviously.

Test Plan

Read PHUIObjectBoxView and select correct method.

Diff Detail

Repository
rP Phabricator
Branch
xhprof-round4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4589
Build 4603: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28537.Feb 20 2015, 10:05 PM
chad retitled this revision from to Fix fatal in XHProf.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 20 2015, 10:05 PM
epriestley accepted this revision.Feb 20 2015, 10:23 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2015, 10:23 PM
Closed by commit rP3304d7a34107: Fix fatal in XHProf (authored by chad, committed by chad). · Explain WhyFeb 20 2015, 11:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
xhprof/
view/
2 lines

Diff 28537

View Options

src/applications/xhprof/view/PhabricatorXHProfProfileSymbolView.php

Loading...
Phabricator · Built by Phacility