Fix fatal in XHProf
ClosedPublic
Actions

Authored by chad on Feb 20 2015, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 7, 1:25 PM

	Unknown Object (File)
	Fri, Dec 6, 11:17 PM

	Unknown Object (File)
	Thu, Dec 5, 1:06 AM

	Unknown Object (File)
	Oct 23 2024, 11:11 PM

	Unknown Object (File)
	Oct 16 2024, 9:34 PM

	Unknown Object (File)
	Oct 11 2024, 6:58 AM

	Unknown Object (File)
	Oct 11 2024, 6:58 AM

	Unknown Object (File)
	Oct 11 2024, 6:58 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP3304d7a34107: Fix fatal in XHProf

Summary

4th times the charm? There is some confusion with Headers that could be simplified, obviously.

Test Plan

Read PHUIObjectBoxView and select correct method.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28537.Feb 20 2015, 10:05 PM

chad retitled this revision from to Fix fatal in XHProf.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 20 2015, 10:05 PM

epriestley accepted this revision.Feb 20 2015, 10:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 10:23 PM

Closed by commit rP3304d7a34107: Fix fatal in XHProf (authored by chad, committed by chad). · Explain WhyFeb 20 2015, 11:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

xhprof/

view/

PhabricatorXHProfProfileSymbolView.php

2 lines

Diff 28538

View Options

src/applications/xhprof/view/PhabricatorXHProfProfileSymbolView.php

Fix fatal in XHProfClosedPublicActions