Page MenuHomePhabricator

Tweak alert states in header a bit more
ClosedPublic

Authored by chad on Feb 20 2015, 8:36 PM.
Tags
None
Referenced Files
F14347839: D11838.diff
Thu, Dec 19, 3:38 AM
Unknown Object (File)
Thu, Nov 28, 11:54 AM
Unknown Object (File)
Tue, Nov 26, 11:53 AM
Unknown Object (File)
Sat, Nov 23, 7:55 PM
Unknown Object (File)
Fri, Nov 22, 3:17 PM
Unknown Object (File)
Nov 11 2024, 7:19 AM
Unknown Object (File)
Nov 4 2024, 9:40 PM
Unknown Object (File)
Oct 28 2024, 11:35 PM
Subscribers
Tokens
"Haypence" token, awarded by sshannin.

Details

Summary

The sky blue colors in the alerts was problematic in other color headers (not black). Rather than hand tweak each color, just going with white seems best. There is also a small animation now, which you may or may not like. It is playful and enjoyable to me at least.

Test Plan

Tested various header colors with and without alert notifications.

Diff Detail

Repository
rP Phabricator
Branch
header-notifications
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4586
Build 4600: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Tweak alert states in header a bit more.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.