Fixes T7256.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7256: Browsing commits sporadically failing with Invalid Argument
- Commits
- Restricted Diffusion Commit
rP3fcc3fdedf20: Diffusion - be sure to properly unserialize result from conduit query
Looked at rXPRF0a7a5f69f5d7 in a local instance. things looked great both pre and post patch.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7256
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4522 Build 4536: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Hrrm -- I would expect this to never work, because the Git and Mercurial pathways in DiffusionMergedCommitsQueryConduitAPIMethod end with:
return DiffusionQuery::loadHistoryForCommitIdentifiers(...)
..and it looks like that always returns objects (DiffusionPathChange objects). Then this will try to decode them, so I'd expect that it breaks the working case on its own.
In particular, it looks like this method does not work when called over HTTP currently (e.g., callsign=XPRF, commit=0a7a5f69f5d7 in the console on this install), so I think DiffusionMergedCommitsQueryConduitAPIMethod needs some return mpull($objects, 'toDictionary'); sort of stuff? Or am I crazy?