Page MenuHomePhabricator
Differential D11787

Fix a minor issue with killing daemons
ClosedPublic
Actions

Authored by epriestley on Feb 17 2015, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 7:58 AM
Unknown Object (File)
Tue, Jan 28, 11:23 AM
Unknown Object (File)
Thu, Jan 23, 8:55 PM
Unknown Object (File)
Thu, Jan 23, 4:45 PM
Unknown Object (File)
Tue, Jan 21, 11:13 AM
Unknown Object (File)
Tue, Jan 21, 8:57 AM
Unknown Object (File)
Fri, Jan 17, 5:45 PM
Unknown Object (File)
Fri, Jan 17, 1:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPb6031a721fea: Fix a minor issue with killing daemons
Summary

Even if you --force, we can't kill PID 0. This sends the process itself the signal, and terminates it.

Test Plan

See D11786.

Diff Detail

Repository
rP Phabricator
Branch
daemon2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4517
Build 4531: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28412.Feb 17 2015, 7:33 PM
epriestley retitled this revision from to Fix a minor issue with killing daemons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 17 2015, 7:33 PM
btrahan accepted this revision.Feb 17 2015, 7:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2015, 7:40 PM
Closed by commit rPb6031a721fea: Fix a minor issue with killing daemons (authored by epriestley, committed by epriestley). · Explain WhyFeb 17 2015, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
management/
4 lines

Diff 28412

View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
Phabricator · Built by Phacility