Fix a minor issue with killing daemons
ClosedPublic
Actions

Authored by epriestley on Feb 17 2015, 7:33 PM.

Tags

None

Referenced Files

	F15416459: D11787.id28430.diff
	Thu, Mar 20, 11:13 AM

	F15412753: D11787.id.diff
	Wed, Mar 19, 2:43 PM

	F15406586: D11787.diff
	Tue, Mar 18, 12:47 PM

	F15366104: D11787.id28430.diff
	Tue, Mar 11, 2:24 PM

	F15360730: D11787.id28412.diff
	Tue, Mar 11, 9:49 AM

	Unknown Object (File)
	Feb 9 2025, 6:04 PM

	Unknown Object (File)
	Feb 3 2025, 10:41 AM

	Unknown Object (File)
	Jan 29 2025, 7:58 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPb6031a721fea: Fix a minor issue with killing daemons

Summary

Even if you --force, we can't kill PID 0. This sends the process itself the signal, and terminates it.

Test Plan

See D11786.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28412.Feb 17 2015, 7:33 PM

epriestley retitled this revision from to Fix a minor issue with killing daemons.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 17 2015, 7:33 PM

btrahan accepted this revision.Feb 17 2015, 7:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2015, 7:40 PM

Closed by commit rPb6031a721fea: Fix a minor issue with killing daemons (authored by epriestley, committed by epriestley). · Explain WhyFeb 17 2015, 10:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementWorkflow.php

4 lines

Diff 28430

View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Fix a minor issue with killing daemonsClosedPublicActions