Restrict font-smoothing to actual buttons
ClosedPublic
Actions

Authored by chad on Feb 16 2015, 1:29 AM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPe3594e0a618d: Restrict font-smoothing to actual buttons

Summary

We use font-smoothing to make better looking buttons, but it makes text buttons look bad.

Test Plan

Test a button in an actionlist, font looks same as other action list items.

Diff Detail

Repository

rP Phabricator

Branch

action-button-smooth

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4505
Build 4519: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28385.Feb 16 2015, 1:29 AM

chad retitled this revision from to Restrict font-smoothing to actual buttons.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 16 2015, 1:29 AM

epriestley accepted this revision.Feb 16 2015, 2:07 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 16 2015, 2:07 AM

Closed by commit rPe3594e0a618d: Restrict font-smoothing to actual buttons (authored by chad, committed by chad). · Explain WhyFeb 16 2015, 2:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-button.css

4 lines

Diff 28385

View Options

resources/celerity/map.php