Clean up blank states on Phriction
ClosedPublic
Actions

Authored by chad on Feb 16 2015, 1:19 AM.

Tags

None

Referenced Files

	F15532596: D11775.id28384.diff
	Wed, Apr 23, 4:32 PM

	F15524040: D11775.diff
	Mon, Apr 21, 5:35 AM

	F15523642: D11775.diff
	Mon, Apr 21, 2:43 AM

	F15423735: D11775.id28386.diff
	Mar 22 2025, 5:28 PM

	F15418676: D11775.diff
	Mar 21 2025, 12:45 AM

	F15398203: D11775.id28384.diff
	Mar 16 2025, 11:47 PM

	F15343907: D11775.id28386.diff
	Mar 10 2025, 1:48 AM

	F15333487: D11775.diff
	Mar 8 2025, 2:38 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T7246: Phriction blank state looks odd

Commits

Restricted Diffusion Commit
rP2bccbe454349: Clean up blank states on Phriction

Summary

Removes odd margin. Also removes min-height on content.

Test Plan

Test a fresh Phriction, and a deleted page.

Diff Detail

Repository

rP Phabricator

Branch

phriction-blank

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4504
Build 4518: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28384.Feb 16 2015, 1:19 AM

chad retitled this revision from to Clean up blank states on Phriction.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 16 2015, 1:19 AM

Tweek background color

epriestley accepted this revision.Feb 16 2015, 2:08 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 16 2015, 2:08 AM

Closed by commit rP2bccbe454349: Clean up blank states on Phriction (authored by chad, committed by chad). · Explain WhyFeb 16 2015, 2:14 AM

This revision was automatically updated to reflect the committed changes.

chad added a task: T7246: Phriction blank state looks odd.Feb 16 2015, 2:45 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-document.css

11 lines

Diff 28384

View Options

resources/celerity/map.php