Differential D11770

When cluster.instance is defined, use it to namespace S3 objects
ClosedPublic
Actions

Authored by epriestley on Feb 15 2015, 12:55 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T7163: Convert Phacility file storage to use S3

Commits

Restricted Diffusion Commit
rP3a8cd60bab41: When cluster.instance is defined, use it to namespace S3 objects

Summary

Ref T7163. This isn't technically necessary but seems generally desirable.

Test Plan

Will deploy S3 in production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28378.Feb 15 2015, 12:55 AM

epriestley retitled this revision from to When cluster.instance is defined, use it to namespace S3 objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7163: Convert Phacility file storage to use S3.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 15 2015, 12:55 AM

btrahan accepted this revision.Feb 16 2015, 7:21 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 16 2015, 7:21 PM

Closed by commit rP3a8cd60bab41: When cluster.instance is defined, use it to namespace S3 objects (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2015, 7:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

engine/

PhabricatorS3FileStorageEngine.php

19 lines

Diff 28397

View Options

src/applications/files/engine/PhabricatorS3FileStorageEngine.php

When cluster.instance is defined, use it to namespace S3 objectsClosedPublicActions