Differential D11760

workboards - make errors from filtering show up
ClosedPublic
Actions

Authored by btrahan on Feb 13 2015, 12:27 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7252: Workboards ignore invalid filters

Commits

Restricted Diffusion Commit
rPe1009614534d: workboards - make errors from filtering show up

Summary

Fixes T7252. The UI is slightly different than in Maniphest - in Maniphest the error shows up at the bottom and here it shows up the top - but I think the UI here makes sense as you see the error right away on the newly returned dialogue?

Test Plan

set "created after" to "assdaasds" and got an error back. set filter to something that should work and it worked

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28358.Feb 13 2015, 12:27 AM

btrahan added a task: T7252: Workboards ignore invalid filters.

btrahan retitled this revision from to workboards - make errors from filtering show up.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 13 2015, 12:27 AM

Looks good to me.

This revision is now accepted and ready to land.Feb 17 2015, 1:05 PM

Closed by commit rPe1009614534d: workboards - make errors from filtering show up (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

13 lines

Diff 28407

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

workboards - make errors from filtering show upClosedPublicActions