Reduce severity of auth provider warning
ClosedPublic
Actions

Authored by epriestley on Feb 7 2015, 7:26 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7208: Improve auth issues warning in Phacility cluster?

Commits

Restricted Diffusion Commit
rP8c568d88d7ab: Reduce severity of auth provider warning

Summary

Ref T7208. Now that we have approvals (new installs are safe by default), take those into account when generating this warning.

Try to soften the warning to cover the case discussed in T7208, hopefully without requiring additional measures.

Test Plan

Screen_Shot_2015-02-07_at_11.24.08_AM.png (1×2 px, 182 KB)

Screen_Shot_2015-02-07_at_11.24.21_AM.png (1×2 px, 196 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28178.Feb 7 2015, 7:26 PM

epriestley retitled this revision from to Reduce severity of auth provider warning.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7208: Improve auth issues warning in Phacility cluster?.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 7 2015, 7:26 PM

chad accepted this revision.Feb 7 2015, 8:01 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 7 2015, 8:01 PM

Closed by commit rP8c568d88d7ab: Reduce severity of auth provider warning (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2015, 10:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

config/

PhabricatorAuthListController.php

88 lines

infrastructure/

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

13 lines

Diff 28180

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php