Page MenuHomePhabricator
Differential D11708

Reduce severity of auth provider warning
ClosedPublic
Actions

Authored by epriestley on Feb 7 2015, 7:26 PM.
Tags
None
Referenced Files
F14069275: D11708.id.diff
Wed, Nov 20, 4:57 AM
F14000848: D11708.id.diff
Fri, Oct 25, 1:43 AM
Unknown Object (File)
Oct 13 2024, 11:08 PM
Unknown Object (File)
Oct 13 2024, 2:45 AM
Unknown Object (File)
Sep 4 2024, 6:01 PM
Unknown Object (File)
Aug 22 2024, 10:41 PM
Unknown Object (File)
Aug 21 2024, 8:51 AM
Unknown Object (File)
Aug 18 2024, 7:22 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7208: Improve auth issues warning in Phacility cluster?
Commits
Restricted Diffusion Commit
rP8c568d88d7ab: Reduce severity of auth provider warning
Summary

Ref T7208. Now that we have approvals (new installs are safe by default), take those into account when generating this warning.

Try to soften the warning to cover the case discussed in T7208, hopefully without requiring additional measures.

Test Plan

Screen_Shot_2015-02-07_at_11.24.08_AM.png (1×2 px, 182 KB)

Screen_Shot_2015-02-07_at_11.24.21_AM.png (1×2 px, 196 KB)

Diff Detail

Repository
rP Phabricator
Branch
authwarn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4378
Build 4391: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28178.Feb 7 2015, 7:26 PM
epriestley retitled this revision from to Reduce severity of auth provider warning.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T7208: Improve auth issues warning in Phacility cluster?.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 7 2015, 7:26 PM
chad accepted this revision.Feb 7 2015, 8:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2015, 8:01 PM
Closed by commit rP8c568d88d7ab: Reduce severity of auth provider warning (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2015, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
config/
88 lines
infrastructure/
internationalization/
translation/
13 lines

Diff 28178

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility