Page MenuHomePhabricator

Use --hex-blob flag in bin/storage dump
ClosedPublic

Authored by Firehed on Feb 6 2015, 8:18 PM.
Tags
None
Referenced Files
F14011480: D11704.diff
Fri, Nov 1, 2:07 AM
F14011235: D11704.id28167.diff
Thu, Oct 31, 9:54 PM
F14009636: D11704.diff
Wed, Oct 30, 9:50 PM
F14002526: D11704.diff
Fri, Oct 25, 7:43 PM
F14002261: D11704.id28167.diff
Fri, Oct 25, 5:03 PM
F13993789: D11704.id28167.diff
Wed, Oct 23, 1:27 AM
F13983708: D11704.id28169.diff
Oct 20 2024, 8:15 AM
F13975198: D11704.diff
Oct 18 2024, 9:11 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP28b23fd789dc: Use --hex-blob flag in bin/storage dump
Summary

mysqldump output can end up having weird encoding issues when raw BLOBs are in the output, preventing the backup restoration from succeeding. This hex-encodes blobs in the dump from the backup workflow causing the output file to only contain ASCII and ensure imports are successful.

Test Plan

Had issues restoring a backup from the original mysqldump command issued by this workflow. Ran the same command with this flag added and I was able to restore the backup.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Firehed retitled this revision from to Use --hex-blob flag in bin/storage dump.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Cool. We compress these anyway (and advise compression) and it looks like this has been around since at least MySQL 5.0, so this should strictly produce less-error-prone dumps.

This revision is now accepted and ready to land.Feb 6 2015, 8:44 PM
This revision was automatically updated to reflect the committed changes.