Page MenuHomePhabricator

Use --hex-blob flag in bin/storage dump
ClosedPublic

Authored by Firehed on Feb 6 2015, 8:18 PM.
Tags
None
Referenced Files
F19018517: D11704.id.diff
Nov 23 2025, 11:23 AM
F19010143: D11704.diff
Nov 22 2025, 2:34 AM
F18987148: D11704.diff
Nov 17 2025, 7:28 PM
F18779194: D11704.id28169.diff
Oct 11 2025, 12:46 PM
F18728868: D11704.diff
Sep 30 2025, 10:13 AM
F18712398: D11704.id.diff
Sep 29 2025, 5:23 AM
F18679782: D11704.id28167.diff
Sep 26 2025, 1:33 AM
F18504846: D11704.id.diff
Sep 5 2025, 12:06 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP28b23fd789dc: Use --hex-blob flag in bin/storage dump
Summary

mysqldump output can end up having weird encoding issues when raw BLOBs are in the output, preventing the backup restoration from succeeding. This hex-encodes blobs in the dump from the backup workflow causing the output file to only contain ASCII and ensure imports are successful.

Test Plan

Had issues restoring a backup from the original mysqldump command issued by this workflow. Ran the same command with this flag added and I was able to restore the backup.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Firehed retitled this revision from to Use --hex-blob flag in bin/storage dump.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Cool. We compress these anyway (and advise compression) and it looks like this has been around since at least MySQL 5.0, so this should strictly produce less-error-prone dumps.

This revision is now accepted and ready to land.Feb 6 2015, 8:44 PM
This revision was automatically updated to reflect the committed changes.