Differential D11698

People - add back "add new user" ui
ClosedPublic
Actions

Authored by btrahan on Feb 5 2015, 8:09 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7181: "Create User" button is missing from People even when viewer has permission

Commits

Restricted Diffusion Commit
rP69f06387cb84: People - add back "add new user" ui

Summary

This got clobbered in D11547. Revive the code but move it up from the base class to the PeopleList controller which is presumably all the main "admin" views. Fixes T7181.

Test Plan

Saw the button once more on /people/...!

Diff Detail

Repository

rP Phabricator

Branch

T7181

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4357
Build 4370: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28146.Feb 5 2015, 8:09 PM

btrahan added a task: T7181: "Create User" button is missing from People even when viewer has permission.

btrahan retitled this revision from to People - add back "add new user" ui.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 5 2015, 8:09 PM

Aaaaaaah. Thanks!

This revision is now accepted and ready to land.Feb 5 2015, 8:13 PM

Closed by commit rP69f06387cb84: People - add back "add new user" ui (authored by btrahan, committed by btrahan). · Explain WhyFeb 5 2015, 8:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleListController.php

17 lines

Diff 28146

View Options

src/applications/people/controller/PhabricatorPeopleListController.php

People - add back "add new user" uiClosedPublicActions