Page MenuHomePhabricator
Differential D11659

Have DifferentialRevisionListView return ObjectBoxView
ClosedPublic
Actions

Authored by chad on Feb 3 2015, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 4:21 PM
Unknown Object (File)
Fri, Dec 6, 1:06 PM
Unknown Object (File)
Sun, Dec 1, 7:15 PM
Unknown Object (File)
Wed, Nov 27, 11:21 PM
Unknown Object (File)
Wed, Nov 27, 11:43 AM
Unknown Object (File)
Thu, Nov 21, 1:35 PM
Unknown Object (File)
Wed, Nov 20, 12:54 PM
Unknown Object (File)
Nov 10 2024, 2:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP4c2e36f561c5: Have DifferentialRevisionListView return ObjectBoxView
Summary

Uses PHUIObjectBoxView to display lists of diffs in Differential and Diffusion, unless embedded on a dashboard.

Test Plan

Test Dashboard panel, Differential home, Commit, and Diff

Screen_Shot_2015-02-03_at_12.39.10_PM.png (1×972 px, 225 KB)

Screen_Shot_2015-02-03_at_12.39.17_PM.png (1×878 px, 223 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff-list-view
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4298
Build 4311: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28066.Feb 3 2015, 8:42 PM
chad retitled this revision from to Have DifferentialRevisionListView return boxes by magic, usually.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 8:42 PM
chad edited the test plan for this revision. (Show Details)Feb 3 2015, 8:43 PM
chad retitled this revision from Have DifferentialRevisionListView return boxes by magic, usually to Have DifferentialRevisionListView return ObjectBoxView.Feb 19 2015, 3:02 PM
chad updated this object.
epriestley accepted this revision.Feb 19 2015, 3:23 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 3:23 PM
Closed by commit rP4c2e36f561c5: Have DifferentialRevisionListView return ObjectBoxView (authored by chad, committed by chad). · Explain WhyFeb 19 2015, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
differential/
controller/
5 lines
query/
3 lines
view/
17 lines
diffusion/
controller/
5 lines
webroot/
rsrc/
css/
application/
dashboard/
4 lines
phui/
4 lines

Diff 28066

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility