Page MenuHomePhabricator

Policy - move some owners code into an editor class and check policy better
ClosedPublic

Authored by btrahan on Feb 3 2015, 7:37 PM.
Tags
None
Referenced Files
F19427128: D11652.id.diff
Sun, Dec 28, 7:58 AM
F19427091: D11652.id28039.diff
Sun, Dec 28, 7:56 AM
F19427090: D11652.id28040.diff
Sun, Dec 28, 7:55 AM
F19216731: D11652.diff
Wed, Dec 17, 7:35 AM
F19196445: D11652.diff
Tue, Dec 16, 1:05 PM
F18872442: D11652.id.diff
Nov 5 2025, 4:19 AM
F18871103: D11652.diff
Nov 4 2025, 9:08 PM
F18820021: D11652.id28040.diff
Oct 22 2025, 12:00 PM
Subscribers

Details

Summary

Ref T7094. We basically need to make sure folks can see repositories before making owners packages about code within. This cleans up things a little bit by moving a bunch of logic out of the storage class and into an editor class.

Test Plan

made a package and it worked! deleted a package and it worked! discovered buggy behavior in more complicated edits and filed T7127; note this bug exists before and after this diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Policy - move some owners code into an editor class and check policy better.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:39 PM
This revision was automatically updated to reflect the committed changes.