Page MenuHomePhabricator
Differential D11649

Restore the "alternate file domain" setup warning and provide CDN instructions
ClosedPublic
Actions

Authored by epriestley on Feb 3 2015, 4:32 PM.
Tags
None
Referenced Files
F14364115: D11649.diff
Fri, Dec 20, 2:17 PM
Unknown Object (File)
Sun, Dec 8, 1:18 PM
Unknown Object (File)
Fri, Dec 6, 5:32 AM
Unknown Object (File)
Nov 4 2024, 4:53 AM
Unknown Object (File)
Oct 25 2024, 2:13 AM
Unknown Object (File)
Oct 23 2024, 5:33 AM
Unknown Object (File)
Oct 18 2024, 4:16 PM
Unknown Object (File)
Oct 15 2024, 5:43 PM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPf96b2583023e: Restore the "alternate file domain" setup warning and provide CDN instructions
Summary

Fixes T2380. Fixes T2382. Users should really configure this, but when we had a warning before a lot of users had trouble with it.

  • Tout performance benefits.
  • Document easy setup via CDN.
  • We have an "Ignore" button now for users who really don't care.
Test Plan
  • Set up admin.phacility.com through AWS CloudFront (need a few changes to handle instances to put it on the cluster in general).
  • Set up secure.phabricator.com through CloudFlare (almost; waiting for DNS).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28032.Feb 3 2015, 4:32 PM
epriestley retitled this revision from to Restore the "alternate file domain" setup warning and provide CDN instructions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: Restricted Maniphest Task, Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 3 2015, 4:32 PM
chad added a subscriber: chad.Feb 3 2015, 5:41 PM

Macro suchwow: nice prose, many words such document

btrahan accepted this revision.Feb 3 2015, 5:53 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/config/check/PhabricatorSecuritySetupCheck.php
53

maybe lose the security prefix? ($file_key has a security prefix already)

This revision is now accepted and ready to land.Feb 3 2015, 5:53 PM
Closed by commit rPf96b2583023e: Restore the "alternate file domain" setup warning and provide CDN instructions (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
25 lines
option/
32 lines
docs/
user/
configuration/
2 lines
108 lines

Diff 28042

View Options

src/applications/config/check/PhabricatorSecuritySetupCheck.php

Loading...
View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php

Loading...
View Options

src/docs/user/configuration/configuration_guide.diviner

Loading...
View Options

src/docs/user/configuration/configuring_file_domain.diviner

Loading...
Phabricator · Built by Phacility