Aphlict - fix incrementation of _messagesIn
ClosedPublic
Actions

Authored by • pmoreau on Feb 3 2015, 3:37 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7124: "messages.in" looks like it isn't getting updated properly in Aphlict

Commits

Restricted Diffusion Commit
rP172566a76975: Aphlict - fix incrementation of _messagesIn

Summary

Ref T7124. The local version of this in the handler of 'end' was incremented rather than the global one.

Test Plan

Sending test notifications did not increment the messages.in value before this patch even if it should have. With the patch sending test notifications does increment messages.in.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• pmoreau updated this revision to Diff 28030.Feb 3 2015, 3:37 PM

• pmoreau retitled this revision from to Aphlict - fix incrementation of _messagesIn.

• pmoreau updated this object.

• pmoreau edited the test plan for this revision. (Show Details)

• pmoreau added a reviewer: epriestley.

• pmoreau added a task: T7124: "messages.in" looks like it isn't getting updated properly in Aphlict.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 3:37 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Feb 3 2015, 4:01 PM

Closed by commit rP172566a76975: Aphlict - fix incrementation of _messagesIn (authored by • pmoreau, committed by epriestley). · Explain WhyFeb 3 2015, 4:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

lib/

AphlictAdminServer.js

2 lines

Diff 28031

View Options

support/aphlict/server/lib/AphlictAdminServer.js

Aphlict - fix incrementation of _messagesInClosedPublicActions