Page MenuHomePhabricator

Aphlict - fix incrementation of _messagesIn
ClosedPublic

Authored by pmoreau on Feb 3 2015, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 6:16 PM
Unknown Object (File)
Tue, Mar 26, 2:44 PM
Unknown Object (File)
Tue, Mar 26, 4:10 AM
Unknown Object (File)
Tue, Mar 26, 4:09 AM
Unknown Object (File)
Tue, Mar 26, 4:09 AM
Unknown Object (File)
Tue, Mar 26, 4:09 AM
Unknown Object (File)
Sat, Mar 23, 8:57 PM
Unknown Object (File)
Wed, Mar 20, 11:18 PM
Subscribers

Details

Summary

Ref T7124. The local version of this in the handler of 'end' was incremented rather than the global one.

Test Plan

Sending test notifications did not increment the messages.in value before this patch even if it should have. With the patch sending test notifications does increment messages.in.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pmoreau retitled this revision from to Aphlict - fix incrementation of _messagesIn.
pmoreau updated this object.
pmoreau edited the test plan for this revision. (Show Details)
pmoreau added a reviewer: epriestley.
This revision is now accepted and ready to land.Feb 3 2015, 4:01 PM
This revision was automatically updated to reflect the committed changes.